Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @2003LK, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
AAZ PR: Azure/aaz#940 |
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the Azure Databricks extension to use API version 2026-01-01, bumping the extension version from 1.3.0 to 1.3.1. The PR includes comprehensive updates to all API command files, test improvements, and a new feature that automatically sets the SKU to "premium" for serverless workspaces when no SKU is explicitly provided.
Changes:
- Upgraded API version from 2025-10-01-preview to 2026-01-01 across all databricks command files
- Added logic to default SKU to "premium" for serverless compute mode workspaces
- Improved test resource group handling by replacing hardcoded resource group names with dynamic references
- Enhanced test reliability by adding --no-wait flags to vnet-peering delete commands to avoid race conditions
Reviewed changes
Copilot reviewed 33 out of 44 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/databricks/setup.py | Version bump from 1.3.0 to 1.3.1 |
| src/databricks/HISTORY.rst | Added release notes for version 1.3.1 documenting the API upgrade and SKU default feature |
| src/databricks/azext_databricks/tests/latest/test_databricks_scenario.py | Replaced hardcoded resource group "auto-test-databricks-g9" with {rg} variable, added --no-wait to vnet-peering delete commands, and added test case for serverless workspace without explicit SKU |
| src/databricks/azext_databricks/tests/latest/recordings/*.yaml | Updated test recordings with new API version 2026-01-01 and current test execution timestamps |
| src/databricks/azext_databricks/aaz/latest/databricks/workspace/_create.py | Updated API version to 2026-01-01 and added logic to set default SKU to "premium" for serverless workspaces |
| src/databricks/azext_databricks/aaz/latest/databricks/workspace/*.py | Updated API version strings from 2025-10-01-preview to 2026-01-01 |
| src/databricks/azext_databricks/aaz/latest/databricks/access_connector/*.py | Updated API version strings from 2025-10-01-preview to 2026-01-01 |
| if sku is not None: | ||
| compute_mode = args.get("compute_mode", None) | ||
| sku_value = args.get("sku", None) | ||
| if (not sku_value or sku_value == "") and compute_mode and compute_mode.lower() == "serverless": |
There was a problem hiding this comment.
The condition checking whether to set a default SKU uses (not sku_value or sku_value == ""). This condition will evaluate to True for various falsy values including 0, False, empty list, etc., which may not be the intended behavior. Consider using a more explicit check like if sku_value is None or sku_value == "" or if not sku_value alone (without the redundant or sku_value == "" part) to make the intention clearer. The current condition with both checks suggests uncertainty about what values to expect.
| if (not sku_value or sku_value == "") and compute_mode and compute_mode.lower() == "serverless": | |
| if (sku_value is None or sku_value == "") and compute_mode and compute_mode.lower() == "serverless": |
| 1.2.1 | ||
| +++++ | ||
| * Upgrade API version from 2025-10-01-preview to 2026-01-01 |
There was a problem hiding this comment.
The HISTORY.rst entry for version 1.2.1 states "Upgrade API version from 2025-10-01-preview to 2026-01-01", but this appears to be misleading since version 1.3.0 shows this change was reverted. This historical entry might confuse users about which version actually contains the API upgrade. Consider clarifying that 1.2.1 was never released or that the change was reverted in 1.3.0 and re-applied in 1.3.1.
| 1.2.1 | |
| +++++ | |
| * Upgrade API version from 2025-10-01-preview to 2026-01-01 | |
| 1.2.1 (unreleased) | |
| +++++ | |
| * Upgrade API version from 2025-10-01-preview to 2026-01-01 (this change was later reverted in 1.3.0 and re-applied in 1.3.1) |
3 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Updated to 2026-01-01
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.